Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colored breaks awesome_print #89

Closed
roberts1000 opened this issue Apr 29, 2019 · 3 comments · Fixed by #90
Closed

colored breaks awesome_print #89

roberts1000 opened this issue Apr 29, 2019 · 3 comments · Fixed by #90
Labels

Comments

@roberts1000
Copy link

Great gem! I've been using cri on a couple projects and it's been working great. A user reported a bug on my rspec_n gem (which uses cri) and stated rspec_n breaks awesome_print when both gems are listed in a Gemfile. I traced the issue back to the colored gem that cri uses and thought I would make sure you were aware (especially since awesome_print is such a popular gem).

colored adds colorize, green, red, etc... methods directly on String. awesome_print does the same thing. The gem that gets listed last in a Gemfile has their implementation loaded by Bundler. If colored is listed last, it breaks awesome_print.

Based on this comment in the awesome_print code, awesome_print seems to have compatibility with the colorize gem (an alternative to colored), but it doesn't seem to know about colored.

@denisdefreyne
Copy link
Owner

Here’s a potential fix: #90.

I argue that coloring text and making it bold is simple enough that it does not require a separate gem.

@denisdefreyne
Copy link
Owner

This is now fixed and released in Cri 2.15.4.

@roberts1000
Copy link
Author

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants