Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need help getting started #1

Open
mchubby opened this issue Aug 5, 2021 · 0 comments
Open

Need help getting started #1

mchubby opened this issue Aug 5, 2021 · 0 comments

Comments

@mchubby
Copy link

mchubby commented Aug 5, 2021

Description

Be it the v1 release or the current HEAD in main, the software does not seem to work out of the box.

NPM

The package.json is fairly straightforward, but in the npm run stage, there are errors complaining about a missing index.js.
I suppose there must be a webpack.config.js that was not included for some reason?

For the main branch, the following line is problematic, because messages.js was not committed:

import { removeFlashMessages } from "./messages/messages.js";

Flask

  • It is not explained how the html templates are generated. I can suppose it's also a part of how assets are built by webpack.
    Also, layout.html does not have a scripts jinja block.

  • There are some missing modules. I still managed to (kind of) run the program by adding those stubs and fixing the imports:

def get_file_from_url(arg1):  # v1
    return None
def get_image_dominant_colors(arg1):  # v1
    raise ValueError("NotImplementedError get_image_dominant_colors")
def get_image_dominant_colors_via_image_url(arg1):
    raise ValueError("NotImplementedError get_image_dominant_colors_via_image_url")
def get_secret_tracks(arg1):
    return None
def fuzzy_match_artist(arg1, arg2, strict=None):
    return None
def prepare_tracks(arg1, arg2):
    return arg1
  • the trivia module is missing, so the blueprint should probably be commented out

  • you should probably provide an etc/config.json.example, e.g.:

{
  "SECRET_KEY": "change this",
  "SERVER_NAME": "127.0.0.1:5000",
  "SQLALCHEMY_DATABASE_URI": "",
  "SPOTIFY_CLIENT_SECRET": "",
  "SPOTIFY_CLIENT_ID": "",
  "SPOTIFY_REDIRECT_URI": "",
  "LASTFM_API_KEY": "",
  "LASTFM_USER_AGENT": "",
  "MUSIC_BRAINZ_USER_AGENT": "",
  "DISCOGS_USER_TOKEN": "",
  "APP_NAME": "My Madness Bracket"
}

in main:

  • set SESSION_TYPE = 'filesystem' in the Config, unless you have guidance for something else?

  • add aiocache and Flask-Session to requirements.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant