Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows builds #522

Merged
merged 7 commits into from
Apr 19, 2021
Merged

Fix Windows builds #522

merged 7 commits into from
Apr 19, 2021

Conversation

denisidoro
Copy link
Owner

No description provided.

README.md Outdated
@@ -1,5 +1,7 @@
# navi <img src="https://user-images.githubusercontent.com/3226564/65362934-b4432500-dbdf-11e9-8f75-815fbc5cbf8f.png" alt="icon" height="28px"/> [![Actions Status](https://github.com/denisidoro/navi/workflows/Tests/badge.svg)](https://github.com/denisidoro/navi/actions) ![GitHub release](https://img.shields.io/github/v/release/denisidoro/navi?include_prereleases)

TODO: windows
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

src/actor.rs Outdated
@@ -65,6 +65,8 @@ fn prompt_finder(
('\n'.to_string(), &None)
};

eprintln!("{}", fs::exe_string()?);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

src/actor.rs Outdated
{{q}}
NAVIEOF
)" "{name}"; {extra}"#,
r#"(@echo.{{+}}NAVIEOF{{q}}NAVIEOF{name}) | {exe} preview-var-win"#,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If windows... else...

src/actor.rs Outdated
@@ -100,7 +96,7 @@ NAVIEOF

if opts.preview_window.is_none() {
opts.preview_window = Some(if extra_preview.is_none() {
format!("up:{}", variable_count + 3)
format!("up:{}", variable_count + 10)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3

@@ -167,6 +167,9 @@ pub enum Command {
/// Typed text
variable: String,
},
/// Used for fzf's preview window when selecting variable suggestions
#[clap(setting = AppSettings::Hidden)]
PreviewVarWin,
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PreviewVarStdin

@denisidoro denisidoro merged commit 2266c1b into master Apr 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the windows/fix branch April 19, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants