Update legacy syntax from Elvish widget #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the legacy assignment and lambda syntax from the Elvish widget so it works on v0.17 without deprecation errors. This commit also refactors some of the code so it's cleaner.
|
Thanks for opening this pull request! |
|
Even though this is a breaking change, the minimum supported version is 1+ year old. I'll assume that if a given user hasn't updated elvish in a while, they won't update navi either, so it's OK. |
|
Congrats on merging your first pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the following legacy syntax from the Elvish widget so it works on v0.17 without deprecation errors:
foo = bar→var foo = barorset foo = bar[arg1 arg2]{ body }→{|arg1 arg2| body }; all the lambdas in the widget have no arguments so they can simply be written as{ body }instead of{|| body }which coincidentally keeps the widget compatible with pre-0.17 versionsThis PR also refactors some of the code so it's cleaner.
As the
varandsetspecial commands were introduced in Elvish v0.15 (January 2021), this updated Elvish widget will only work in versions 0.15 and up, so this PR is technically a breaking change.