KnetArray general broadcasting

[denizyuret]

KnetArray supports broadcasting for scalar-array, vector-array (vector can have multiple dims but only a single dim > 1), and array-array if they have the same dimensions. General array-array broadcasting for multidimensional arrays is complicated and needs to be implemented. The existing implementations are in cuda12gen.jl.

[denizyuret]

Ilker do we have any missing broadcasting ops? Does everything work in 10, 20 dimensions?

[ilkerkesen]

isapprox fails (I guess this is because of too many accumulated rounding errors) but they work without any error.

[denizyuret]

how bad does it fail? can we get it to pass by modifying atol and rtol options to isapprox?

[denizyuret]

@ilkerkesen are we missing any broadcasting ops? should we close this?

[ilkerkesen]

We can close this issue, too.

…

On Dec 24, 2017 7:01 PM, "denizyuret" ***@***.***> wrote: @ilkerkesen <https://github.com/ilkerkesen> are we missing any broadcasting ops? should we close this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#38 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACrjQ3nRGvWhD3dX4o_4P_W3Ck84R3LRks5tDnVYgaJpZM4KwX6v> .