This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
refactor: improve locale types/errors #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request aims to improve types for translate functions (
client.languages.manager.get(locale, key, ?args)).In the actual implementation, the key command:ban/complete requires 2 parameters. If a developer tries to use this key without providing any argument, no error is thrown and the developer will only know about the error after testing the command.
The changes in this PR are incomplete and not tested yet. The improved types are only available on CommandLocale (
t('key')) & LanguageManager.TODO: pin dependencies