Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Group ended before it began" Discussion #1

Closed
MauAbata opened this issue Jun 7, 2021 · 1 comment
Closed

"Group ended before it began" Discussion #1

MauAbata opened this issue Jun 7, 2021 · 1 comment

Comments

@MauAbata
Copy link

MauAbata commented Jun 7, 2021

Came here from the PIO thread, since I had a similar error. It seems a couple pairs of -Wl,--start-group/-Wl,--end-group flags are being set out of order on the linker command. These flags come from the esp-adf-libs and esp-sr submodules in their CMakeLists.txt file.

As a temporary workaround, I've removed them in my local copy of esp-adf and it will compile against PlatformIO just fine without issues regarding circular dependencies. It looks like those flags were added in later in the file history, just before IDF v4 support was added to esp-adf.

I'm curious why the linker command is being generated with flags out of order from these component lists. The list of libraries included between the flags are also removed. Hopefully this points us in a somewhat useful direction.

Also, in these CMake files, the IDF_VER variable won't be correct, this is fixed on the latest dev branch of the platform: platformio/platform-espressif32#558

@denmuellner
Copy link
Owner

denmuellner commented Aug 29, 2021

Hi there,

just a few days ago someone came along with a painfully simple fix for this. There was indeed an additional -Wl,--end-group somewhere in the CMakeLists.txt files of the modules you mentioned. To fix this, a simple unflag command can be added in the platform.ini file. I just updated the repo also adding one of the ADF-examples.

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants