Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore commented lines #18

Closed
AFriemann opened this issue Apr 8, 2019 · 2 comments
Closed

ignore commented lines #18

AFriemann opened this issue Apr 8, 2019 · 2 comments

Comments

@AFriemann
Copy link
Contributor

The config loader logic isn't aware of commented lines and seems to pick them up anyway - I think this shouldn't happen.

I think they could easily be dropped here

func (l *ipSecConfigurationLoader) extractLines(ipsecConfig string) []string {

Let me know if you agree and I'll gladly supply a PR

@dennisstritzke
Copy link
Owner

I definitely agree.

Thanks for bringing this up and I am happy to review your PR.

@AFriemann
Copy link
Contributor Author

just pinging you again @dennisstritzke in case you didn't see the PR. Let me know if you have any requests! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants