Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Issue with SandWicher.sol #1

Open
psilmana opened this issue Feb 1, 2023 · 7 comments
Open

Issue with SandWicher.sol #1

psilmana opened this issue Feb 1, 2023 · 7 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@psilmana
Copy link

psilmana commented Feb 1, 2023

When i use this contract to buy any token my transaction is being sandwiched by some other bot and i loss good amount..
Please check these transaction at this address

https://bscscan.com/address/0xfab57ceb826c4df8a2087b0494c00999dbfcdf79

@dennohpeter
Copy link
Owner

dennohpeter commented Feb 1, 2023

I will look into this tomorrow, in the meantime I would advise not to use the contract as is, it is not optimised enough, and you are lucky you didn't get into a rug. There is a lot of missing rug checks and slippage that I've not incorporated in this version

@dennohpeter dennohpeter added good first issue Good for newcomers bug Something isn't working labels Feb 1, 2023
@psilmana
Copy link
Author

psilmana commented Feb 2, 2023

Hi thanks for responding and updating on issues this contract has.
Eagerly waiting for your advice

@psilmana
Copy link
Author

psilmana commented Feb 5, 2023

Any update?

@psilmana
Copy link
Author

Hi you seems to be busy so if you want we can work on this on paid basis

@dennohpeter
Copy link
Owner

Hey @psilmana sorry had been busy for a while, one thing you can do to avoid being sandwiched is getting reserves offchain and checking if the are have changed onchain in the s.c if the have that means someone bought b4 you so just return or revert

@dennohpeter dennohpeter self-assigned this Mar 14, 2023
@psilmana
Copy link
Author

psilmana commented Apr 2, 2023

Hi I did that it resolved the issue of being sandwiched but now the transactions are failing

@dennohpeter
Copy link
Owner

dm on telegram at @dennohpeter we debug

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants