Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use it in deno tests #13

Closed
bjesuiter opened this issue Nov 5, 2022 · 3 comments
Closed

Can't use it in deno tests #13

bjesuiter opened this issue Nov 5, 2022 · 3 comments

Comments

@bjesuiter
Copy link
Contributor

I want to use this in deno tests for easier visibility of long running downloads.

However, because you check this isTTY flag, i can't use it :(

I've disabled this check now locally for me, but it would be nice, If i could simply use your package from upstream.

Is there any reason we might need this isTTY check especially?

@fuxingZhang
Copy link
Collaborator

@bjesuiter
Landed in v1.2.9

@fuxingZhang
Copy link
Collaborator

v1.3.0 is published.

changes:

  1. fixed colored string length calculation bug

  2. Deno.consoleSize is now stable

Deno v1.27.0 : Stabilize Deno.consoleSize() API

The Deno.consoleSize API change

- Deno.consoleSize(Deno.stdout.rid).columns;
+ Deno.consoleSize().columns;

Now you can run a wider bar without unstable.

- deno run --unstable ./examples/width.unstable.ts
+ deno run ./examples/width.ts

So mod.unstable.ts and exmaples/width.unstable.ts was removed.

- mod.unstable.ts
- exmaples/width.unstable.ts

@bjesuiter
Copy link
Contributor Author

Thanks very much for fast reaction and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants