Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis.scan cursor parameter requires a number #391

Open
chromakode opened this issue Jun 12, 2023 · 0 comments
Open

Redis.scan cursor parameter requires a number #391

chromakode opened this issue Jun 12, 2023 · 0 comments
Labels
enhancement New feature or request
Projects

Comments

@chromakode
Copy link

scan takes a number cursor:

redis/redis.ts

Lines 2278 to 2281 in fb773be

scan(
cursor: number,
opts?: ScanOpts,
) {

The cursor returned by this method is a string, so it needs to be coerced to pass back into the next iteration of scan.

In contrast, hscan takes a string cursor:

redis/redis.ts

Lines 2288 to 2292 in fb773be

sscan(
key: string,
cursor: number,
opts?: SScanOpts,
) {

Should the cursor param of scan be changed to a string?

@uki00a uki00a added this to To do in v1 Jul 15, 2023
@uki00a uki00a added the enhancement New feature or request label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
v1
To do
Development

No branches or pull requests

2 participants