Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-eslint recommended rules #86

Closed
21 tasks done
bartlomieju opened this issue Jun 2, 2020 · 11 comments
Closed
21 tasks done

typescript-eslint recommended rules #86

bartlomieju opened this issue Jun 2, 2020 · 11 comments
Labels
Milestone

Comments

@bartlomieju
Copy link
Member

bartlomieju commented Jun 2, 2020

Tracking issues for recommended rules of typescript-eslint

https://github.com/typescript-eslint/typescript-eslint/blob/v3.1.0/packages/eslint-plugin/src/configs/recommended.ts

  • adjacent-overload-signatures (easy)
  • ban-ts-comment
  • ban-types
  • explicit-module-boundary-types (easy)
  • no-array-constructor
  • no-empty-function (needs to be fixed, false positives for constructors)
  • no-empty-interface
  • no-explicit-any
  • no-extra-non-null-assertion
  • no-extra-semi (easy)
  • no-inferrable-types (easy)
  • no-misused-new
  • no-namespace
  • no-non-null-asserted-optional-chain
  • no-non-null-assertion
  • no-this-alias
  • no-unused-vars (hard, needs scope analysis)
  • no-var-requires
  • prefer-as-const
  • prefer-namespace-keyword
  • triple-slash-reference
@lucacasonato
Copy link
Member

I don't think no-var-requires makes sense for us: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-var-requires.md

@bartlomieju bartlomieju added this to the 0.2.0 milestone Jun 7, 2020
@bartlomieju
Copy link
Member Author

I've marked this issue with 0.2.0 milestone. I want to implement remaining rules this week so they will be included in deno v1.1

@disizali
Copy link
Contributor

disizali commented Jun 8, 2020

@bartlomieju
i'm almost done with no-this-alias and ban-ts-comment,
Also no-inferrable-types is my next goal.
you can start the rest first.

@iykekings
Copy link
Contributor

I'm working on no-non-null-asserted-optional-chain and no-non-null-assertion.

@bartlomieju bartlomieju mentioned this issue Jun 18, 2020
9 tasks
@bartlomieju bartlomieju pinned this issue Jun 18, 2020
@bartlomieju
Copy link
Member Author

@iykekings are you still working on no-non-null-asserted-optional-chain?

@iykekings
Copy link
Contributor

Yes, had plenty on my plate at work. I will try to finish it ASAP

@magurotuna
Copy link
Member

I'm working on adjacent-overload-signatures.

@magurotuna
Copy link
Member

I'll take no-inferrable-types next.

@humancalico
Copy link
Contributor

@bartlomieju It seems no-inferrable-types is done. It's not updated in your comment

@notfilippo
Copy link
Contributor

notfilippo commented Jul 29, 2020

Taking explicit-module-boundary-types 😄

@bartlomieju
Copy link
Member Author

Done with #267

@bartlomieju bartlomieju unpinned this issue Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants