rfac: split actions across multiple jobs #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
wperron
requested changes
May 21, 2021
There was a problem hiding this comment.
This is a good start but will need a bit more work:
- the
Docker buildstep should be moved to thebuildjob -- we used to need it before the tests because the tests depended on it, but that is no longer the case - the
ValidateandCreate terraform plansteps can be moved to thedeployjob
|
Sorry we never got around to merging this. It's a priority for us right now, so I'll close this PR unmerged to reflect that. Thanks for the effort though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #228
This splits the existing github-actions workflow, which is currently contained in a single job, into a pipeline of multiple jobs namely