-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deno_registry2 must reject broken module #239
Comments
We already have process that goes through every file to |
I deploy test_manager, I clean (not intended) one file content commit this brok my code, then I publish can't be used by any body because is invalid I'd like deno registry to reject invalid code and notify dev deploying this. |
Yeah I'm sorry, I'm not 100% clear on what you're asking here? "Broken code" could mean a couple of different things, it could mean that imports and broken, it could mean that there's syntax errors and it doesn't parse in v8, or it could mean a variety of other things. What's the flow you're looking for? What kind of errors do you want the registry to catch and how? |
I think he means that you should check if the third party modules is work before publishing them on the Deno registry if(checkIsValidThirParty(incomingThirdPartyModule)){
publishToDenoRegistry(incomingThirdPartyModule)
}else{
makeReportToModuleOwner(incomingThirdPartyModule)
} |
I would assume that broken code means that it is code that won't run. functi on ree() {
return "ree";
} And if things like this happen then the registry should reject the code. |
thanks for response. |
I think deno registry must check the module befor add them to deno.land/x store, if the code is invalid (like deno deploy check) or have'nt description inform the contributor. this will be help develop to get "save" code from deno.land/x, this may need some convention about enty/entries poins for modules or manifest.
The text was updated successfully, but these errors were encountered: