Merge branch 'main' into string_width

.github/workflows/ci.yml

@@ -102,7 +102,7 @@ jobs:
     runs-on: ubuntu-22.04
     strategy:
       matrix:
-        module: [ { name: crypto, path: ./crypto/_wasm }, { name: varint, path: ./encoding/varint/_wasm } ]
+        module: [ crypto/_wasm ]
     steps:
       - name: Clone repository
         uses: actions/checkout@v3
@@ -117,10 +117,10 @@ jobs:
         run: |-
           set -o errexit
           shopt -s inherit_errexit
-          declare modifications="$(git diff --name-only HEAD~ -- ${{ matrix.module.path }})"
+          declare modifications="$(git diff --name-only HEAD~ -- ${{ matrix.module }})"
           declare modified="$([[ "$modifications" ]] && echo true || echo false)"
           echo "modified=$modified" >> $GITHUB_OUTPUT
-          echo "${{ matrix.module.name }} WASM source modified in this commit? $modified"
+          echo "${{ matrix.module }} WASM source modified in this commit? $modified"
           echo "$modifications"
 
       - name: Set up Deno
@@ -138,4 +138,4 @@ jobs:
 
       - name: Rebuild Wasm and verify it hasn't changed
         if: success() && steps.source.outputs.modified == 'true'
-        run: deno task build:${{ matrix.module.name }} --check
+        run: deno task build:${{ matrix.module }} --check

.gitignore

@@ -4,6 +4,5 @@
 .vim
 **/cov/
 /crypto/_wasm/target
-/encoding/varint/_wasm/target
 deno.lock
 /string_width/testdata/unicode_width_crate/target

README.md

@@ -90,15 +90,14 @@ Ensure there is a related issue and it is referenced in the PR text.
 
 _About CI checks_:
 
-We currently have 7 checks on CI. Each PR should pass all of these checks to be
+We currently have 6 checks on CI. Each PR should pass all of these checks to be
 accepted.
 
 - test with Deno canary on Windows
 - test with Deno canary on Linux
 - test with Deno canary on macOS
 - lint
 - wasm crypto check
-- wasm varint check
 - CLA
 
 _For maintainers_:

Releases.md

@@ -1,3 +1,14 @@
+### 0.182.0 / 2023.03.31
+
+- feat(csv): add `CsvStringifyStream` (#3270)
+- feat(fs): undo deprecation of `exists` and add permission and type check to it
+  (#2785)
+- feat(fs/walk): WalkError class (#3054)
+- feat: disposition on TextDelimiterStream (#3273)
+- fix(csv/csv_stringify_stream): output headers based on `columns` option
+  (#3293)
+- fix(encoding/base58): fix base58 decoding missing the first byte (#3275)
+
 ### 0.181.0 / 2023.03.22
 
 - feat(front_matter): support +++ for TOML block (#3254)

_tools/check_deprecation.ts

@@ -16,7 +16,6 @@ const EXCLUDED_PATHS = [
   "http/_negotiation",
   "crypto/_wasm",
   "crypto/_fnv",
-  "encoding/varint/_wasm",
   "encoding/_yaml",
   "encoing/_toml",
   "_tools",

_tools/check_licence.ts

@@ -8,7 +8,6 @@ const EXCLUDED_DIRS = [
   "**/fs/testdata",
   "**/http/testdata",
   "**/crypto/_wasm/target",
-  "**/encoding/varint/_wasm/target",
 ];
 
 const ROOT = new URL("../", import.meta.url);

bytes/bytes_list.ts

@@ -129,15 +129,19 @@ export class BytesList {
     const startIdx = this.getChunkIndex(start);
     const endIdx = this.getChunkIndex(end - 1);
     let written = 0;
-    for (let i = startIdx; i < endIdx; i++) {
-      const chunk = this.#chunks[i];
-      const len = chunk.end - chunk.start;
-      result.set(chunk.value.subarray(chunk.start, chunk.end), written);
+    for (let i = startIdx; i <= endIdx; i++) {
+      const {
+        value: chunkValue,
+        start: chunkStart,
+        end: chunkEnd,
+        offset: chunkOffset,
+      } = this.#chunks[i];
+      const readStart = chunkStart + (i === startIdx ? start - chunkOffset : 0);
+      const readEnd = i === endIdx ? end - chunkOffset + chunkStart : chunkEnd;
+      const len = readEnd - readStart;
+      result.set(chunkValue.subarray(readStart, readEnd), written);
       written += len;
     }
-    const last = this.#chunks[endIdx];
-    const rest = end - start - written;
-    result.set(last.value.subarray(last.start, last.start + rest), written);
     return result;
   }
   /**

bytes/bytes_list_test.ts

@@ -102,6 +102,16 @@ Deno.test("[bytes] BytesList.add should throw if invalid range", () => {
 });
 Deno.test("[bytes] BytesList.slice", () => {
   const arr = setup();
+
+  const arrWithContent = new BytesList();
+  const te = new TextEncoder();
+  const td = new TextDecoder();
+
+  arrWithContent.add(te.encode("Some dummy example "), 2, 13);
+  arrWithContent.add(te.encode("to show it does work now"), 5, 20);
+  assertEquals(td.decode(arrWithContent.slice(5, 9)), "mmy ");
+  assertEquals(td.decode(arrWithContent.slice(9, 13)), "exow");
+
   assertEquals(
     bytes.equals(arr.slice(0, 4), new Uint8Array([0, 1, 2, 3])),
     true,

deno.json

@@ -9,7 +9,6 @@
       "exclude": [
         ".git",
         "crypto/_wasm/target",
-        "encoding/varint/_wasm/target",
         "cov",
         "jsonc/testdata",
         "front_matter/testdata",
@@ -23,7 +22,6 @@
       "exclude": [
         ".git",
         "crypto/_wasm/target",
-        "encoding/varint/_wasm/target",
         "jsonc/testdata",
         "front_matter/testdata",
         "cov",
@@ -40,7 +38,6 @@
     "lint:check-assertions": "deno run --allow-read --allow-net ./_tools/check_assertions.ts",
     "lint": "deno lint && deno task fmt:licence-headers --check && deno task lint:deprecations && deno task lint:doc-imports && deno task lint:check-assertions",
     "build:crypto": "deno task --cwd crypto/_wasm wasmbuild",
-    "build:varint": "deno task --cwd encoding/varint/_wasm wasmbuild",
     "wasmbuild": "deno run --unstable -A https://deno.land/x/wasmbuild@0.10.3/main.ts --js-ext mjs --sync"
   }
 }

encoding/varint.ts

@@ -7,8 +7,6 @@
  * @module
  */
 
-export * from "./varint/mod.ts";
-
 // This implementation is a port of https://deno.land/x/varint@v2.0.0 by @keithamus
 // This module is browser compatible.