Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove findLast and findLastIndex from std/collections #1525

Closed
lucacasonato opened this issue Nov 5, 2021 · 6 comments
Closed

Remove findLast and findLastIndex from std/collections #1525

lucacasonato opened this issue Nov 5, 2021 · 6 comments

Comments

@lucacasonato
Copy link
Member

This feature is landing as a native JS feature in V8 9.7. https://v8.dev/blog/v8-release-97#findlast-and-findlastindex-array-methods
@LionC
Copy link
Contributor

LionC commented Nov 5, 2021

Let's do that once that is released!

@getspooky
Copy link
Contributor

I agree with @LionC

@lucacasonato
Copy link
Member Author

@LionC Will be in 1.16 on Tuesday.

This was referenced Nov 6, 2021
Merged
Merged
@kt3k
Copy link
Member

kt3k commented Nov 7, 2021

How about deprecating first before removing?

@getspooky
Copy link
Contributor

The function is still available using native JS feature in V8 9.7, I suggest that we add alert message in the documentation for example:

`findLastIndex` is available as native function in javascript. learn more https://v8.dev/blog/v8-release-97#findlast-and-findlastindex-array-methods

@lucacasonato lucacasonato mentioned this issue Nov 8, 2021
Merged
@erfanium
Copy link
Contributor

@lucacasonato i guess this issue should be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kt3k @LionC @lucacasonato @bartlomieju @getspooky @erfanium