Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: tracking issue for Vite #2055

Closed
7 tasks done
kt3k opened this issue Mar 23, 2022 · 3 comments
Closed
7 tasks done

compat: tracking issue for Vite #2055

kt3k opened this issue Mar 23, 2022 · 3 comments
Assignees

Comments

@kt3k
Copy link
Member

kt3k commented Mar 23, 2022

This issue tracks the issues for executing basic example of vite in compat mode

A typical workflow we try to support is:

yarn create vite
cd vite-project
yarn
yarn dev

With deno compat mode warpper script (the script should be named node and in your $PATH):

#!/bin/sh
DENO_NODE_COMPAT_URL=file:///path/to/your/deno_std/ deno run --no-check --unstable --compat -A $@

(DENO_NODE_COMPAT_URL=... part is optional)

@bartlomieju
Copy link
Member

Tentative implementation of ReadStream: #1435

@lino-levan
Copy link
Contributor

Is this issue still relevant since the --compat flag has been removed? Vite support is more or less here (minus the need for the node_modules folder, rollup seems blocked on that) from what I've seen from community projects

@kt3k
Copy link
Member Author

kt3k commented Nov 1, 2022

Let's close this as the basic features of vite work now via npm: specifier.

ref: https://www.youtube.com/watch?v=Zjojo9wdvmY

Is this issue still relevant since the --compat flag has been removed?

npm module compatibility issues are still relevant. Please replace --compat part with npm: specifier when reading them. --compat and npm: uses the same underlying API shims (which is std/node). So many issues should apply for both.

@kt3k kt3k closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants