Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: Use Node streams v4 for streams implementation #2374

Closed
bartlomieju opened this issue Jun 20, 2022 · 2 comments
Closed

node: Use Node streams v4 for streams implementation #2374

bartlomieju opened this issue Jun 20, 2022 · 2 comments
Assignees
Labels
node Related to node compatibility layer

Comments

@bartlomieju
Copy link
Member

bartlomieju commented Jun 20, 2022

Starting with v18, Node uses "streams v4" as a default stream implementation: https://github.com/nodejs/readable-stream/releases/tag/v4.0.0

We should create a Deno build and use it instead of our hand rolled implementation.

Suggested by @benjamingr in denoland/deno#12577 (comment)

CC @cjihrig

Ref nodejs/readable-stream#451

@bartlomieju bartlomieju added the node Related to node compatibility layer label Jun 20, 2022
@cjihrig cjihrig self-assigned this Jun 20, 2022
@cjihrig
Copy link
Contributor

cjihrig commented Sep 4, 2022

This was closed by #2584.

@cjihrig cjihrig closed this as completed Sep 4, 2022
@benjamingr
Copy link
Contributor

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Related to node compatibility layer
Projects
None yet
Development

No branches or pull requests

3 participants