Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make encoding/yaml.ts type-compatible with Deno Deploy #907

Closed
kt3k opened this issue May 10, 2021 · 2 comments · Fixed by #912
Closed

Make encoding/yaml.ts type-compatible with Deno Deploy #907

kt3k opened this issue May 10, 2021 · 2 comments · Fixed by #912

Comments

@kt3k
Copy link
Member

kt3k commented May 10, 2021

Currently yaml can't be used in Deploy because of the following errors:

$ deployctl run test.ts 
Check file:///Users/kt3k/tmp/deploy-test/$deno$eval.ts
error: TS2694 [ERROR]: Namespace 'Deno' has no exported member 'Reader'.
  async readFrom(r: Deno.Reader): Promise<number> {
                         ~~~~~~
    at https://deno.land/std@0.95.0/io/buffer.ts:196:26

TS2694 [ERROR]: Namespace 'Deno' has no exported member 'ReaderSync'.
  readFromSync(r: Deno.ReaderSync): number {
                       ~~~~~~~~~~
    at https://deno.land/std@0.95.0/io/buffer.ts:226:24

Found 2 errors.
error: Process exited with code 1
@wperron
Copy link
Contributor

wperron commented May 10, 2021

Maybe we could add Reader and Writer types to Deploy? 🤔

@lucacasonato
Copy link
Member

Plan to fix this in denoland/deno#9795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants