Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collections): add maxWith #1170

Merged
merged 4 commits into from
Sep 4, 2021
Merged

feat(collections): add maxWith #1170

merged 4 commits into from
Sep 4, 2021

Conversation

majidsajadi
Copy link
Contributor

this PR adds maxWith to the collections module.

@LionC
Copy link
Contributor

LionC commented Aug 26, 2021

My comment from minWith applies here as well. It might actually make sense to put them in one PR to be honest, as the code will be very similar as well^^

@LionC LionC mentioned this pull request Aug 27, 2021
Closed
44 tasks
LionC
LionC suggested changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@LionC LionC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small doc input, which applies to minWith as well. The rest looks good to me.

collections/max_with.ts Outdated Show resolved Hide resolved
kt3k
kt3k approved these changes Sep 4, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majidsajadi LGTM. Thank you for your contribution!

@LionC Thank you for your reviews!

@kt3k kt3k merged commit e872b75 into denoland:main Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LionC LionC LionC requested changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@majidsajadi @LionC @kt3k