Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(collections): add reduceGroups #1187

Merged
merged 4 commits into from
Sep 6, 2021
Merged

feat(collections): add reduceGroups #1187

merged 4 commits into from
Sep 6, 2021

Conversation

majidsajadi
Copy link
Contributor

No description provided.

@majidsajadi majidsajadi marked this pull request as draft August 30, 2021 15:18
@LionC LionC mentioned this pull request Aug 31, 2021
Closed
44 tasks
@majidsajadi majidsajadi mentioned this pull request Sep 3, 2021
Closed
@majidsajadi majidsajadi marked this pull request as ready for review September 4, 2021 17:26
@majidsajadi
Copy link
Contributor Author

@LionC Review please

LionC
LionC reviewed Sep 5, 2021
View reviewed changes
collections/reduce_groups.ts Outdated Show resolved Hide resolved
LionC
LionC approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@LionC LionC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pingin @kt3k . Even though the implementation looks obvious, I think this is worth it, because if you want to do this cleanly, there is a lot of nesting that is distracting. But I will leave the decision to you :-)

kt3k
kt3k approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majidsajadi LGTM. Thank you for your contribution!

@LionC I think this utility does enough complex operation, and has enough flexibility (you can provide any reducer). I agree with the inclusion! 👍

@kt3k kt3k merged commit 1d56e28 into denoland:main Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@LionC LionC LionC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@majidsajadi @kt3k @LionC