feat(collections): add sample #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
reviewed
Sep 9, 2021
collections/_utils.ts
Outdated
| /** | ||
| * Produces a random number between the inclusive `lower` and `upper` bounds. | ||
| */ | ||
| export function randomNumber(lower: number, upper: number) { |
There was a problem hiding this comment.
Because it uses Math.floor, I guess it's better to name this randomIntegerNumber
There was a problem hiding this comment.
Or randomInteger, the number part is kind of redundant there :-)
kt3k
reviewed
Sep 9, 2021
collections/sample.ts
Outdated
| * const numbers = [1, 2, 3, 4]; | ||
| * const random = sample(numbers); | ||
| * | ||
| * assert(numbers.includes(random)); |
There was a problem hiding this comment.
this seems causing type error in doc testing. you can check that with the command
deno test --doc collections/sample.ts
kt3k
approved these changes
Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
samplefunction tocollectionsmodule. #1173