chore: upgrade wasmbuild to 0.6 #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
approved these changes
Jun 17, 2022
kt3k
reviewed
Jun 17, 2022
|
|
||
| ### CI | ||
|
|
||
| If CI fails in `Verify Wasm hasn't changed` step, you need to download built |
There was a problem hiding this comment.
Does this mean there is no diffs anymore in the built wasm based on the platforms?
There was a problem hiding this comment.
Yeah there’s no diffs. If the inputs are the same then the CI will pass. If someone builds on Windows then the output will be slightly different than if someone build on Linux, but the output should be functionally the same. So if the CI fails they should only have to run the deno task regardless of their OS, then recommit and it should pass the CI.
There was a problem hiding this comment.
Thanks for the clarification! Makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--js-ext mjsflag to output anmjsextension--checkflag for verifying the output is up to date (works across operating systems)