Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added formatter i I (w/ Deno.inspect) #3100

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Added formatter i I (w/ Deno.inspect) #3100

merged 2 commits into from
Jan 17, 2023

Conversation

imjamesb
Copy link
Contributor

Added a formatter that uses Deno.inspect.

@CLAassistant
Copy link

CLAassistant commented Jan 12, 2023

CLA assistant check
All committers have signed the CLA.

fmt/printf.ts Outdated Show resolved Hide resolved
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
@imjamesb
Copy link
Contributor Author

Done

@kt3k
Copy link
Member

kt3k commented Jan 12, 2023

I'm in favor of this addition. Does anyone have any concern on this?

@iuioiua
Copy link
Collaborator

iuioiua commented Jan 12, 2023

LGTM

@lino-levan
Copy link
Contributor

I see no reason not to. LGTM!

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 7afd7e2 into denoland:main Jan 17, 2023
bartlomieju pushed a commit to bartlomieju/deno_std that referenced this pull request Feb 1, 2023
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants