Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(http): deprecate ServerSentEvent() #3783

Merged
merged 3 commits into from
Nov 12, 2023
Merged

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Nov 9, 2023

In favour of ServerSentEventStream() introduced in #3751.

@github-actions github-actions bot added the http label Nov 9, 2023
@iuioiua iuioiua marked this pull request as ready for review November 9, 2023 01:07
@iuioiua iuioiua requested a review from kt3k as a code owner November 9, 2023 01:07
@iuioiua iuioiua changed the title BREAKING: deprecate ServerSentEvent() BREAKING(http): deprecate ServerSentEvent() Nov 9, 2023
Copy link
Contributor

@lino-levan lino-levan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 0dd0e3a into main Nov 12, 2023
12 checks passed
@iuioiua iuioiua deleted the deprecate-server-sent-event branch November 12, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants