Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(async): remove deprecated deferred() #3852

Merged
merged 1 commit into from
Nov 24, 2023
Merged

BREAKING(async): remove deprecated deferred() #3852

merged 1 commit into from
Nov 24, 2023

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Nov 24, 2023

This was deprecated in favour of Promise.withResolvers().

@github-actions github-actions bot added the async label Nov 24, 2023
@iuioiua iuioiua marked this pull request as ready for review November 24, 2023 03:06
@iuioiua iuioiua requested a review from kt3k as a code owner November 24, 2023 03:06
kt3k
kt3k approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit d7f3d8c into main Nov 24, 2023
12 checks passed
@iuioiua iuioiua deleted the remove-async-deferred branch November 24, 2023 08:11
realpha pushed a commit to realpha/deno_std that referenced this pull request Nov 24, 2023
@iuioiua @realpha
BREAKING(async): remove deprecated deferred() (denoland#3852)
dd48a07
@joyzheng joyzheng mentioned this pull request Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
async
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iuioiua @kt3k