Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation(log): deprecate LogLevels.WARNING #4170

Merged
merged 2 commits into from
Jan 12, 2024
Merged

deprecation(log): deprecate LogLevels.WARNING #4170

merged 2 commits into from
Jan 12, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jan 12, 2024 •
edited
Loading

Related #4117

PTAL @timreichen

@iuioiua iuioiua requested a review from kt3k as a code owner January 12, 2024 02:39
@github-actions github-actions bot added the log label Jan 12, 2024
@kt3k
Copy link
Member

kt3k commented Jan 12, 2024

Can you fix the test cases?

kt3k
kt3k approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit fc816ef into main Jan 12, 2024
12 checks passed
@iuioiua iuioiua deleted the deprecate-LogLevels.WARNING branch January 12, 2024 05:07
@iuioiua iuioiua mentioned this pull request Jan 12, 2024
Closed
@iuioiua iuioiua mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iuioiua @kt3k