Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(io): rework deprecations #4197

Closed
wants to merge 1 commit into from
Closed

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jan 14, 2024

This change reworks std/io deprecations by bringing the removal version forward to v0.215.0 from v1, and providing alternative solutions for advanced I/O use.

It seems that the wide-use of copy(), readAll(), writeAll() and Buffer justified having a removal version of v1. But now that these APIs have been undeprecated, I think it's reasonable to remove the other, more advanced, but less-used std/io APIs sooner.

@iuioiua iuioiua requested a review from kt3k as a code owner January 14, 2024 22:45
@github-actions github-actions bot added the io label Jan 14, 2024
@iuioiua iuioiua enabled auto-merge (squash) January 15, 2024 04:04
Comment on lines +57 to +58
* @deprecated (will be removed in 0.215.0) Use
* {@linkcode https://deno.land/std/io/buffer.ts | Buffer} instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is BufReader usage covered by Buffer?

@iuioiua
Copy link
Collaborator Author

iuioiua commented Feb 22, 2024

It appears this is no longer needed.

@iuioiua iuioiua closed this Feb 22, 2024
auto-merge was automatically disabled February 22, 2024 00:38

Pull request was closed

@iuioiua iuioiua deleted the rework-io-deprecations branch February 22, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants