deprecation(streams): rework deprecations #4199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
commented
Jan 15, 2024
| @@ -35,7 +35,7 @@ export type { Reader, ReaderSync }; | |||
| * } | |||
| * ``` | |||
| * | |||
| * @deprecated (will be removed after 1.0.0) Use {@linkcode ReadableStream} instead. | |||
| * @deprecated (will be removed in 0.215.0) Use {@linkcode ReadableStream} instead. | |||
| */ | |||
| export async function* iterateReader( | |||
There was a problem hiding this comment.
Reader is usually present alongside a ReadableStream, and therefor ReadableStreamDefaultReader.
| @@ -20,7 +20,7 @@ import type { Reader } from "../io/types.ts"; | |||
| * await copy(reader, file); | |||
| * ``` | |||
| * | |||
| * @deprecated (will be removed after 1.0.0) Use {@linkcode ReadableStreamDefaultReader} directly. | |||
| * @deprecated (will be removed after 0.215.0) Use {@linkcode ReadableStreamDefaultReader} directly. | |||
There was a problem hiding this comment.
The Streams API, when used with std/streams, has the same functionality as std/io. There shouldn't be a reason for someone to go from using streams to Reader/Writer interfaces.
|
|
||
| /** | ||
| * Options for {@linkcode writableStreamFromWriter}. | ||
| * | ||
| * @deprecated (will be removed after 1.0.0) Use {@linkcode WritableStream} directly. | ||
| * @deprecated (will be removed in 0.215.0) Use | ||
| * {@linkcode https://deno.land/std/io/to_writable_stream.ts | toWritableStream} |
There was a problem hiding this comment.
This is simply a correction of the deprecation notice + moving the version forward.
|
I'll come back to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reworks
std/streamsdeprecations for various reasons (see comments). I think it's reasonable to bring some of the removal versions forward because: