Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(console): rename _rle to _run_length.ts #4212

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

timreichen
Copy link
Contributor

This PR renames _rle to _run_length.ts.

I have no idea what these exported functions actually do. It might be a good idea to add jsdoc as well.

@kt3k
Copy link
Member

kt3k commented Jan 16, 2024

I have no idea what these exported functions actually do. It might be a good idea to add jsdoc as well.

cc @lionel-rowe

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@iuioiua iuioiua merged commit 41fd03f into denoland:main Jan 16, 2024
12 checks passed
@timreichen timreichen deleted the console_rename_unclear_name branch January 16, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants