Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(console): prepare for noUncheckedIndexedAccess #4269

Merged
merged 2 commits into from
Feb 2, 2024
Merged

refactor(console): prepare for noUncheckedIndexedAccess #4269

merged 2 commits into from
Feb 2, 2024

Conversation

eryue0220
Copy link
Contributor

Ref: #4040

@eryue0220 eryue0220 requested a review from kt3k as a code owner February 2, 2024 03:34
@eryue0220 eryue0220 changed the title refactor(console): prepare for noUncheckedIndexedAccess refactor(console): prepare for noUncheckedIndexedAccess Feb 2, 2024
kt3k
kt3k approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit b77b51a into denoland:main Feb 2, 2024
12 checks passed
@eryue0220 eryue0220 deleted the console-noUncheckedIndexedAccess branch February 2, 2024 09:23
eryue0220 added a commit to eryue0220/deno_std that referenced this pull request Feb 2, 2024
@eryue0220
Merge branch 'crypto-noUncheckedIndexedAccess' of github.com:eryue022…
40df5e4 
…0/deno_std into crypto-noUncheckedIndexedAccess

* 'crypto-noUncheckedIndexedAccess' of github.com:eryue0220/deno_std:
  refactor(console): prepare for `noUncheckedIndexedAccess` (denoland#4269)
  refactor(collections): prepare for `noUncheckedIndexedAccess` (denoland#4268)
  refactor(semver): cleanup comparison functions (denoland#4266)
  chore(semver): postpone removal versions of some APIs (denoland#4267)
  BREAKING(log): remove `WARNING` log level (denoland#4258)
  BREAKING(semver): remove `rangeFormat()` (denoland#4265)
  BREAKING(semver): remove `sort()` (denoland#4264)
  BREAKING(path): remove `separator.ts` files (denoland#4260)
  BREAKING(path): remove `glob.ts` files (denoland#4259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
console
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eryue0220 @kt3k