Addition of CSV #432
Merged
Addition of CSV #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ry
reviewed
May 23, 2019
encoding/csv/test.ts
Outdated
| @@ -0,0 +1,2 @@ | |||
| // Copyright 2018-2019 the Deno authors. All rights reserved. MIT license. | |||
| import "./mod_test.ts"; | |||
ry
reviewed
May 23, 2019
encoding/csv/mod.ts
Outdated
| @@ -0,0 +1,139 @@ | |||
| import { BufReader, BufState } from "../../io/bufio.ts"; | |||
There was a problem hiding this comment.
Rename file to encoding/csv.ts
Please add
// Ported from Go:
// https://github.com/golang/go/blob/go1.12.5/src/encoding/csv/
// Copyright 2018-2019 the Deno authors. All rights reserved. MIT license.
Merged
|
Remains weird cases with double quotes and multiline in fields to handle. For me it's landable now and tests are already here. So if you want to land it now i'm OK. There is a TODO comment added for remaining cases |
ry
reviewed
May 24, 2019
ry
reviewed
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently work in progress.
Ported tests from golang
EDIT:
Remaining quotes and CRLF tests to fix and we're done.