Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bytesRepeat #446

Merged
merged 2 commits into from
May 24, 2019
Merged

add bytesRepeat #446

merged 2 commits into from
May 24, 2019

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented May 24, 2019 •
edited
Loading

  1. fix [bytes] No test cases running #445
  2. add bytesRepeat for bytes

Because I need bytesRepeat() in the other modules, and it is also the Go module https://golang.org/pkg/bytes/#Repeat.

@axetroy axetroy changed the title add bytesRepeat and fix #445 add bytesRepeat May 24, 2019
ry
ry approved these changes May 24, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit bd46d60 into denoland:master May 24, 2019
@axetroy axetroy deleted the bytes branch May 24, 2019 12:12
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@axetroy @ry
Enable bytes tests and add bytesRepeat (denoland/std#446)
4ab0e0e 
Original: denoland/std@bd46d60
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bytes] No test cases running
2 participants
@axetroy @ry