Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(flags): remove std/flags #4644

Merged
merged 4 commits into from
Apr 26, 2024
Merged

BREAKING(flags): remove std/flags #4644

merged 4 commits into from
Apr 26, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Apr 24, 2024

To be merged right before JSR cutover.

Towards #4544

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.93%. Comparing base (fc035e9) to head (ad72223).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4644   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         479      479           
  Lines       37399    37399           
  Branches     5310     5310           
=======================================
  Hits        34008    34008           
  Misses       3329     3329           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the flags label Apr 24, 2024
@github-actions github-actions bot added the flags label Apr 24, 2024
@iuioiua iuioiua marked this pull request as ready for review April 25, 2024 03:05
@iuioiua iuioiua requested a review from kt3k as a code owner April 25, 2024 03:05
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k changed the title BREAKING(flags): remove std/flags [unstable] BREAKING(flags): remove std/flags Apr 26, 2024
@kt3k kt3k changed the title [unstable] BREAKING(flags): remove std/flags BREAKING(flags): remove std/flags Apr 26, 2024
@iuioiua iuioiua merged commit 80cff5c into main Apr 26, 2024
17 checks passed
@iuioiua iuioiua deleted the remove-flags branch April 26, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants