-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: "Frequently Asked Questions" page #4722
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4722 +/- ##
=======================================
Coverage 91.44% 91.44%
=======================================
Files 480 480
Lines 37318 37318
Branches 5316 5316
=======================================
Hits 34126 34126
Misses 3136 3136
Partials 56 56 ☔ View full report in Codecov by Sentry. |
.github/FAQ.md
Outdated
follows: | ||
|
||
```ts, ignore | ||
import { bar } from "jsr:@std/foo@1/bar"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deno add <pkg>
adds import map entry with the form of "@std/foo": "jsr:@std/foo@^1.2.3"
. The above example seems slightly inconsistent with it to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, what are you suggesting? I changed it to jsr:@std/foo@^1
. How's that?
I wonder this is a right place to document this information. How about adding these sections in "Standard Library" page of deno-docs https://docs.deno.com/runtime/manual/basics/standard_library ? |
Almost all information on the Standard Library should be contained within this repo. It doesn't sense to disperse this information elsewhere. |
Maybe this topic is out of scope of this PR, but the issue with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hopfully, jsr-io/jsr#507 fixes that. I would be happy to discuss it elsewhere. |
First pass. Other questions that should be answered:
@kt3k, are you able to handle these?