Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(fs): improve expandGlob() implementation and testing #5089

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 19, 2024

This PR improves the line coverage of fs/expand_glob.ts.

part of #3713

@github-actions github-actions bot added the fs label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (41a2da4) to head (879f0f8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5089      +/-   ##
==========================================
+ Coverage   92.44%   92.56%   +0.11%     
==========================================
  Files         481      481              
  Lines       38732    38708      -24     
  Branches     5446     5454       +8     
==========================================
+ Hits        35806    35829      +23     
+ Misses       2871     2824      -47     
  Partials       55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua iuioiua changed the title refactor(fs): improve expandGlob implementaion and testing refactor(fs): improve expandGlob() implementation and testing Jun 19, 2024
fs/expand_glob.ts Show resolved Hide resolved
fs/expand_glob_test.ts Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should move advanceMatch() generator functions out of their respective expandGlob[Sync]() functions as advanceMatch() and advanceMatchSync().

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Perhaps we can move advanceMatch() out of these functions in a follow-up PR.

@kt3k kt3k merged commit bd55f3b into denoland:main Jun 20, 2024
15 checks passed
@kt3k kt3k deleted the improve-expand-glob branch June 20, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants