Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/module): More descriptive error in "createRequire" when invalid URL scheme is used #997

Merged
merged 1 commit into from
Jul 2, 2021
Merged

fix(node/module): More descriptive error in "createRequire" when invalid URL scheme is used #997

merged 1 commit into from
Jul 2, 2021

Conversation

TotallyNotChase
Copy link
Contributor

Closes #955

@CLAassistant
Copy link

CLAassistant commented Jul 2, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

wperron
wperron approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@wperron wperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@wperron wperron merged commit 1914407 into denoland:main Jul 2, 2021
@TotallyNotChase TotallyNotChase deleted the createRequire-scheme-errmsg branch July 2, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wperron wperron wperron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno 1.9.0, Uncaught InvalidData: invalid url scheme
3 participants
@TotallyNotChase @CLAassistant @wperron