Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to parse exit command args should return 2 exit code #108

Closed
dsherret opened this issue Jan 27, 2024 · 0 comments · Fixed by #112
Closed

Failure to parse exit command args should return 2 exit code #108

dsherret opened this issue Jan 27, 2024 · 0 comments · Fixed by #112
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dsherret
Copy link
Member

dsherret commented Jan 27, 2024 •
edited

Just found this comment in Dax (written by someone else, not me):

https://github.com/dsherret/dax/blob/c885ba58ba52035a6cf99629dbcac90209a94604/src/commands/exit.ts#L13

This line should be changed to 2 it seems:

deno_task_shell/src/shell/commands/exit.rs

Line 26 in 26ef383

ExecuteResult::Exit(1, Vec::new())

@dsherret dsherret added bug Something isn't working good first issue Good for newcomers labels Jan 27, 2024
@dsherret dsherret mentioned this issue Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: exit error code on arg parse failure dsherret/deno_task_shell
1 participant
@dsherret