Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make SqliteMessageHandle methods public #35

Merged
merged 1 commit into from Nov 14, 2023
Merged

Conversation

igorzi
Copy link
Collaborator

@igorzi igorzi commented Nov 14, 2023

We need these methods for the NPM module. QueueMessageHandle interface has #[async_trait::async_trait(?Send)], so it can't be used with multithreaded tokio runtime.

Copy link
Member

@losfair losfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove ?Send on QueueMessageHandle instead?

@igorzi igorzi enabled auto-merge (squash) November 14, 2023 18:01
@igorzi igorzi closed this Nov 14, 2023
auto-merge was automatically disabled November 14, 2023 18:09

Pull request was closed

@igorzi igorzi reopened this Nov 14, 2023
@igorzi igorzi merged commit 0dbd088 into main Nov 14, 2023
7 of 8 checks passed
@igorzi igorzi deleted the queue_handle_public branch November 14, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants