Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shim is injected for global type name when local type of same name exists #35

Closed
dsherret opened this issue Nov 16, 2021 · 2 comments · Fixed by #40
Closed

Shim is injected for global type name when local type of same name exists #35

dsherret opened this issue Nov 16, 2021 · 2 comments · Fixed by #40
Labels
bug Something isn't working

Comments

@dsherret
Copy link
Member

The following should stay as-is because there exists a local Response type:

interface Response {}

function test(r: Response) {}

But instead the following happens:

import * as denoShim from "deno.ns";

interface Response {}

function test(r: denoShim.Response) {}
@dsherret dsherret added the bug Something isn't working label Nov 16, 2021
@zandaqo
Copy link

zandaqo commented Nov 17, 2021

Similar situation with code targeting browsers: usage of Response/Request triggers shimming deno.ns.

@dsherret
Copy link
Member Author

@zandaqo will discuss that one in #37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants