Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark mode toggle #43

Open
kitsonk opened this issue Dec 16, 2021 · 1 comment
Open

dark mode toggle #43

kitsonk opened this issue Dec 16, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@kitsonk
Copy link
Contributor

kitsonk commented Dec 16, 2021

Any chance we could get a toggle in a follow up?

Originally posted by @bartlomieju in #41 (review)

@kitsonk kitsonk added the enhancement New feature or request label Dec 16, 2021
@kitsonk kitsonk self-assigned this Dec 17, 2021
@adiabatic
Copy link

I had a look at https://deno.com/blog/office-hours-update and this section caught my eye:

  • Andy And Tim are excited about our user survey and can't wait to talk about more results soon, but for now we're wondering, does anyone have any magic wishes for Deno's documentation? Folks indicated that it could be improved, but weren't very specific, so we just want to let everyone know hailing frequencies are open!

I'd like to second dark-mode support for the Deno documentation. I'm happy enough with pages that are either light or dark depending on whatever the browser tells the page through prefers-color-scheme, but other people like having manual toggles for this sort of thing, so maybe it might be best to start out with an auto/light/dark three-way toggle.

The only other dark-mode-related feature I'd ask for is to ensure there are no Flashes of Unstyled Content; normally, FOUCs are merely briefly ugly in light mode, but in dark mode, if the FOUC is essentially html { background: white; }, then that's about as pleasant as a surprise flashlight flash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants