Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Benchmark charts - bad values for throughput and exec time #61

Closed
bartlomieju opened this issue Oct 25, 2019 · 5 comments
Closed

Benchmark charts - bad values for throughput and exec time #61

bartlomieju opened this issue Oct 25, 2019 · 5 comments

Comments

@bartlomieju
Copy link
Member

Zrzut ekranu 2019-10-25 o 13 25 13

If you check latest benchmarks (https://github.com/denoland/deno/runs/274208380) you can see that both of those charts should be <2s but all of the results are >4s on charts.

CC @lucacasonato @ry
@lucacasonato
Copy link
Member

Interesting - seems to happen only after interacting with the normalized toggle. I'll look into this.

@lucacasonato
Copy link
Member

Seems to be related to the logarithmic scaling of the graphs. I don't quite understand what exactly is causing the undesired behavior - I'll look into this some more.

@lucacasonato lucacasonato mentioned this issue Oct 29, 2019
Closed
@lucacasonato
Copy link
Member

I think this does not happen anymore.

@bartlomieju
Copy link
Member Author

I can still reproduce it

@lucacasonato
Copy link
Member

Fixed by #408

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: use recharts for benchamark charts luca-rand/deno_website2
2 participants
@lucacasonato @bartlomieju