Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change handler signature from (ctx) => resp to (req, ctx) => resp #113

Closed
lucacasonato opened this issue Mar 6, 2022 · 0 comments · Fixed by #114
Closed

Change handler signature from (ctx) => resp to (req, ctx) => resp #113

lucacasonato opened this issue Mar 6, 2022 · 0 comments · Fixed by #114
Assignees
@crowlKats
Labels
feat New feature or request good first issue Good for newcomers
Milestone
1.0

Comments

@lucacasonato
Copy link
Member

The current signature is somewhat clumsy. It does not align nicely with the signature for serve from deno.land/std.

The req property from ctx should be removed. The match property from ctx should be renamed to params.

This is a prerequisite for #96.
@lucacasonato lucacasonato added the good first issue Good for newcomers label Mar 6, 2022
@crowlKats crowlKats mentioned this issue Mar 6, 2022
Merged
@lucacasonato lucacasonato added this to the 0.1.0 milestone Mar 6, 2022
@lucacasonato lucacasonato added the feat New feature or request label Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crowlKats crowlKats

Labels
feat New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

refactor: detach request from context crowlKats/fresh
2 participants
@lucacasonato @crowlKats