Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins don't support islands #1471

Closed
deer opened this issue Jul 18, 2023 · 2 comments · Fixed by #1472
Closed

Plugins don't support islands #1471

deer opened this issue Jul 18, 2023 · 2 comments · Fixed by #1472

Comments

@deer
Copy link
Contributor

deer commented Jul 18, 2023 •
edited

When I added route and middleware support for plugins, I forgot that islands are handled completely differently. We need to add this functionality in order for plugins to be truly useful. I am working on a fix.

Thoughts?
@marvinhagemeister
Copy link
Collaborator

+1 Makes sense that plugins should be able to inject their own islands too.

@deer
Copy link
Contributor Author

deer commented Jul 18, 2023

I have it working. Just trying to clean things up.

@deer deer mentioned this issue Jul 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(server): plugins can create islands deer/fresh
2 participants
@marvinhagemeister @deer