Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deno when clicking on "Deno X.YY.Z (Upgrade available)" #1024

Closed
nicolo-ribaudo opened this issue Dec 30, 2023 · 3 comments
Closed
Assignees

Comments

@nicolo-ribaudo
Copy link

Is your feature request related to a problem? Please describe.

image

When I see this button my first automatic reaction is to click on it to trigger the update, but instead it just opens the Deno LSP Output panel.

Describe the solution you'd like

It would be great if, when there is an upgrade available, clicking on that showed a popup asking "Do you want to upgrade now? Yes/No" :)

@bartlomieju
Copy link
Member

That's pretty reasonable - I think @nayeemrmn wanted to do it at the first pass, but I can't figure out now why we didn't do that. @nayeemrmn do you think this is feasible to tackle in the near future?

@nayeemrmn
Copy link
Collaborator

nayeemrmn commented Jan 2, 2024

That's the current behaviour, when you click on it it shows a notification to upgrade:
image

@nicolo-ribaudo Maybe you have do-not-disturb or something, does it show if you click on the notifications icon on the bottom left right?

@nicolo-ribaudo
Copy link
Author

When I opened this issue I didn't know about vscode's do-not-disturb mode, and I had it enabled. It's working properly 😅

@nicolo-ribaudo nicolo-ribaudo closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants