Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive error messages when using mis-matched Deno versions? #1074

Closed
Nezteb opened this issue Feb 20, 2024 · 1 comment
Closed

Comments

@Nezteb
Copy link

Nezteb commented Feb 20, 2024

Is your feature request related to a problem? Please describe.

Long story short, I couldn't get 1.35.x to work with this extension at all, despite the docs specifying "v1.13.0 or later". Bumping up to 1.40.x resolved the issue, but the original 1.35.x error message was quite vague:

Starting Deno language server...
  version: 1.35.0 (release, aarch64-apple-darwin)
  executable: /Users/noah/.local/share/mise/installs/deno/1.35.0/bin/deno
Connected to "Visual Studio Code - Insiders" 1.87.0-insider
Cannot set workspace settings: invalid type: null, expected a boolean
[Error - 12:59:53 PM] Server initialization failed.
  Message: Internal error
  Code: -32603 
[Error - 12:59:53 PM] Deno Language Server client: couldn't create connection to server.
  Message: Internal error
  Code: -32603 

See #1063 (comment) for more backstory.

Describe the solution you'd like

I am not sure because I never did figure out why 1.35.x wasn't working, so I don't know if this is even feasible. Regarding an error message, maybe something like below?

[Warning - 12:59:53 PM] Current Deno version 1.35.0 does not support feature XYZ, please use 1.40.x instead
@nayeemrmn
Copy link
Collaborator

This isn't feasible because we don't track the minimum CLI version for the current extension version, we track the range of valid extension versions for each CLI version. It's not invertible and it's very hard to keep track of separately. You can use the table at https://github.com/denoland/vscode_deno?tab=readme-ov-file#compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants