Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent deno fmt result between 1.41.3 and 1.42.0 #1099

Closed
jeiea opened this issue Mar 31, 2024 · 4 comments
Closed

Inconsistent deno fmt result between 1.41.3 and 1.42.0 #1099

jeiea opened this issue Mar 31, 2024 · 4 comments

Comments

@jeiea
Copy link
Contributor

jeiea commented Mar 31, 2024

Steps to reproduce

  1. Environment
    • deno: 1.42.0 (release, x86_64-pc-windows-msvc)
    • vscode_deno: v3.36.0
    • vscode: 1.87.2 (system setup)
  2. Clone the repository and be careful with branch fmt-ignored.
    git clone https://github.com/jeiea/deno_report.git -b fmt-ignored
  3. Open cloned directory with vscode and vscode_deno.
  4. Press Ctrl+s on main.ts.

Expected behavior

The file should remain unchanged compared to when it was run with Deno version 1.41.3 or when the command deno fmt was executed.

Actual behavior

Code_240331212316-317.mp4
@nayeemrmn
Copy link
Collaborator

Do you have deno.documentPreloadLimit: 0 set in your vscode user settings? If so this will be fixed by denoland/deno#23123.

@jeiea
Copy link
Contributor Author

jeiea commented Mar 31, 2024

Do you have deno.documentPreloadLimit: 0 set in your vscode user settings?

No, I haven't seen that. And I can reproduce this just by changing deno binary.

@nayeemrmn
Copy link
Collaborator

Ah, okay your deno.enablePaths must include deno.json now. This is an intentional change in behaviour from 1.41.3, it makes sense. Closing for now but comment here if it's not fixed.

@jeiea
Copy link
Contributor Author

jeiea commented Apr 9, 2024

It's fixed, just I think this should be documented because it's hard to expect and silent breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants