feat: custom git repository root #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/basePath: chore(release): 1.24.0 feat: add show, diff, log as api chore(release): 1.23.0 feat: reworked diff view handling fix: refresh source control view on exception
Vinzent03
requested changes
Mar 21, 2022
|
Great feedback. I updated the setting to add more clarity and to use relative paths. I did use an absolute path during development. I agree that it makes more sense for it to be a relative path. |
|
When testing locally, I noticed that you forgot to add |
Vinzent03
approved these changes
Mar 25, 2022
|
Awesome, thanks for your help. I didn't see anything in the analyzer, I may have missed it though. Also nice catch on the separator. Haven't written anything cross platform before and didn't think about the separator. Let me know if you need anything else to merge, I'm not able to because I don't have write access. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For my use case, I wanted to have a public blog live within my obsidian vault. This blog is hosted and built on github pages and is a normal git repository. To keep things separated, the git repository be in a subfolder not at the root of the vault. This is unsupported currently and referenced in a few issues:
Solution
A setting was added called bath path that allows users to set a custom git root. This is then used by
simple-gitwhen configuring the SimpleGit RepoManger.Limitations
A user is only allowed on repo in the entire vault. I evaluated having multiple git repo support but it turned out to be a larger refactor than I had time for. For my use case this is totally fine.
Thanks for the great plugin!