Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mobile doesn't use .gitignore #297

Closed
NomarCub opened this issue Sep 6, 2022 · 4 comments
Closed

[Bug]: Mobile doesn't use .gitignore #297

NomarCub opened this issue Sep 6, 2022 · 4 comments

Comments

@NomarCub
Copy link

NomarCub commented Sep 6, 2022

Describe the bug

Here are my rules to ignore Obsidian plugins:

.obsidian/plugins/**/**js
.obsidian/plugins/**/manifest.json
.obsidian/plugins/**/styles.css

They work on Windows but not on android, the files are listed in changes.

The Checkout progress: Analyzing workdir: message also counts up above 1000 even though I have like half that many files tops, which is suspicious and looks related.

image

Relevant errors (if available)

No response

Steps to reproduce

Make a gitignore mentioned above in root.

Expected Behavior

No response

Addition context

No response

Operating system

Android

Plugin version

2.0.3

@Vinzent03
Copy link
Collaborator

Vinzent03 commented Sep 7, 2022

Gitignore should works, but maybe your syntax is not supported by the underlying lib? That's strange

@NomarCub
Copy link
Author

NomarCub commented Sep 7, 2022

Could you help me test the underlying lib? I looked around and didn't find docs on isogit's gitignore and I get errors running isogit cli on desktop.

@Vinzent03
Copy link
Collaborator

Vinzent03 commented Sep 7, 2022

I think your syntax is wrong. **.js is wrong.** Should only be used for directories. Please try *.js instead. See the documentation

@NomarCub
Copy link
Author

NomarCub commented Sep 7, 2022

Thanks, your suggestion worked!

My syntax could be better, but it's not wrong for matching these files. It works on Windows, Linux WSL, Termux and MGit on Android. In the doc you linked it says that any non-leading, non-trailing or not /-enclosed ** gets treated as normal asterisks, which match anything. I'll file an issue upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants