fix: update settings grammar #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PScoriae
force-pushed
the
update-notice-grammar
branch
from
6e1b92f
to
5e6f7b5
Compare
- use "minute" when autoSaveInterval is 1 - else use "minutes" - uses the formatMinutes function
PScoriae
force-pushed
the
update-notice-grammar
branch
from
5e6f7b5
to
9267fee
Compare
PScoriae
changed the title
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What my changes do:
formatMinutesfunctionautoBackupAfterFileChangepluginI did think about omitting the interval value if it's set to 1 i.e.:
But I believe being more explicit with whatever interval value the user has set reinforces the idea that the application has registered their input.